Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Relay Warning for adventuring in Spookyraven Cellar #2248

Merged
merged 1 commit into from Mar 28, 2024

Conversation

Veracity0
Copy link
Contributor

Rather than simply offering the chance to adventure in the Haunted Wine Cellar or Haunted Laundry Room if you have not read the mortar-dissolving recipe with Lord Spookyraven's Spectacles equipped, offer to get the recipe (which will autoread it, if autoQuest is true), equip specs, read the recipe.

It will do none of the above if you don't have the spectacles.

@Veracity0 Veracity0 requested a review from a team as a code owner March 28, 2024 15:12
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.58%. Comparing base (94f46c7) to head (3ca88c8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2248      +/-   ##
============================================
+ Coverage     37.57%   37.58%   +0.01%     
- Complexity    19890    19898       +8     
============================================
  Files          1110     1110              
  Lines        169680   169699      +19     
  Branches      35836    35842       +6     
============================================
+ Hits          63759    63785      +26     
  Misses        95816    95816              
+ Partials      10105    10098       -7     
Files Coverage Δ
...net/sourceforge/kolmafia/request/RelayRequest.java 39.41% <100.00%> (+1.32%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f46c7...3ca88c8. Read the comment docs.

Copy link
Contributor

@jaadams5 jaadams5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cartesian test - new tool for me. Thank you.

@Veracity0 Veracity0 merged commit 81ddf4f into main Mar 28, 2024
8 checks passed
@Veracity0 Veracity0 deleted the cellar-warning branch March 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants