New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Savage beast tweaks #2249
Savage beast tweaks #2249
Conversation
Veracity0
commented
Mar 28, 2024
- Cannot uneffect Mild-Mannered Professor and Savage Beast intrinsics
- Savage Beast cannot use NPC stores.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
============================================
- Coverage 37.58% 37.58% -0.01%
Complexity 19900 19900
============================================
Files 1110 1110
Lines 169699 169701 +2
Branches 35842 35843 +1
============================================
- Hits 63787 63783 -4
- Misses 95812 95817 +5
- Partials 10100 10101 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
In case you are wondering.
What the fuck happened? Gausie could have approved my PR before submitting his PR, but does he read/approve PRs anymore, or only submit them? My personal policy is that I only look at PRs from people who look at MY PRs. You are either part of the dev community or you are not. |
I made that PR quickly in response to ask observation I made while communicating directly with Ryo. I actually made it entirely from the command line, so didn’t even see any waiting PRs in passing. Yesterday was my first day back at my job since taking 3 months of paternity leave which frees me up a little for contributing here, something I’ve otherwise struggled to do on a cycle of baby duty and recovery time. I’m looking forward to reviewing PRs again, though I have done so on a few occasions during my mini absence. I suppose the last point is that my PR doesn’t just help “only” me, no need to include something so obviously incorrect when expressing how you feel. |
I apologize for my tone and obvious incorrectness. |
Gausie's PR looked trivial, so I scanned it over and approved it; this one looked a bit more complicated, so I was going to get to it later. |