Improvement for JS ecosystem

[gausie]

Currently kolmafia can't be imported outside of a KoLmafia environment because ESM knows that the named exports aren't actually there. I would like to do this so I can share code between the web and a mafia script, knowing that I will not actually execute mafia-specific code. This fixes that

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 37.70%. Comparing base (81a0fd4) to head (4cbd87a).
Report is 2 commits behind head on main.

❗ Current head 4cbd87a differs from pull request most recent head 8cdb247. Consider uploading reports for the commit 8cdb247 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2270      +/-   ##
============================================
+ Coverage     37.63%   37.70%   +0.06%     
- Complexity    19938    19970      +32     
============================================
  Files          1110     1111       +1     
  Lines        169787   169839      +52     
  Branches      35866    35857       -9     
============================================
+ Hits          63905    64043     +138     
+ Misses        95752    95664      -88     
- Partials      10130    10132       +2     

Files	Coverage Δ
...rceforge/kolmafia/textui/TypescriptDefinition.java	90.45% <60.00%> (-2.29%)	⬇️

... and 12 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1ac30...8cdb247. Read the comment docs.

[jaadams5]

Not that I totally understand what is happening but I trust that it works and doesn't break anything "normal" KolMafia users use.

[gausie]

Without usage statistics I would imagine most KoLmafia users execute JS scripts at least once day, which this could affect if it were wrong.

[gausie]

Small mistake in the github action, I will push to main to fix.

[Veracity0]

Without usage statistics I would imagine most KoLmafia users execute JS scripts at least once day, which this could affect if it were wrong.

I would be astonished if this were true.

Perhaps you mean "most KoLmafia users who are on Discord" - which I am sure is a minority of all KoLmafia users.

[gausie]

No I didn't mean that at all. I really just mean garbage-collector which is frequently mentioned in in-game chat, moreso than any other script I see referenced by name. But again, my anecdote and I could easily be wrong. Just a comment in passing really.

…

On Tue, 9 Apr 2024 at 17:12, Veracity0 ***@***.***> wrote: Without usage statistics I would imagine most KoLmafia users execute JS scripts at least once day, which this could affect if it were wrong. I would be astonished if this were true. Perhaps you mean "most KoLmafia users who are on Discord" - which I am sure is a minority of all KoLmafia users. — Reply to this email directly, view it on GitHub <#2270 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABL4LVNFRBGCRYWAT2P5UTY4QHP3AVCNFSM6AAAAABF4RMQ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVGU3TSOJQGA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[midgleyc]

Without usage statistics I expect most KoLmafia users don't execute any scripts at all.