Export each function separately to ease automocking #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alongside typescript definitions we create a header file that will be imported when someone tries to load the kolmafia typescript library outside of KoLmafia. Each function simply throws an error. So far, a single function was exported under all function names. This prevents a feature employed by some testing libaries called automocking, where each function is automatically replaced with a mocked version, because all functions then reference the same mock. Instead, export a separate function for each library function, and use named function syntax to ensure the function objects have a name.
gausie
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alongside typescript definitions we create a header file that will be imported when someone tries to load the kolmafia typescript library outside of KoLmafia. Each function simply throws an error.
So far, a single function was exported under all function names. This prevents a feature employed by some testing libaries called automocking, where each function is automatically replaced with a mocked version, because all functions then reference the same mock. Instead, export a separate function for each library function, and use named function syntax to ensure the function objects have a name.