Fix AshStub function matching for empty aggregates #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling an ash function from Javascript, the code tries to determine a type for empty arrays/aggregates based on the expected parameter type. It first matches the function with ANY type, and then passes a typeHint to the ValueConverter to generate an empty typed array/aggregate. However, ANY type on the right hand side of a parameter match does not match with anything else than an ANY parameter. Instead, replace any ANY type values with the expected target type during matching, and replace it with the hinted empty aggregate in the second run. Furthermore, the previous implementation effectively does nothing, since it did not used the values from the second run. Fix this, and improve performance by not converting all parameters twice even when no ANY types are used.
gausie
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling an ash function from Javascript, the code tries to determine a type for empty arrays/aggregates based on the expected parameter type. It first matches the function with ANY type, and then passes a typeHint to the ValueConverter to generate an empty typed array/aggregate.
However, ANY type on the right hand side of a parameter match does not match with anything else than an ANY parameter. Instead, replace any ANY type values with the expected target type during matching, and replace it with the hinted empty aggregate in the second run.
Furthermore, the previous implementation effectively does nothing, since it did not used the values from the second run. Fix this, and improve performance by not converting all parameters twice even when no ANY types are used.