Represent JS undefined as void, not string #2291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's the same test that failed last time on Windows. Seems flaky. |
Currently, JS `undefined` is silently converted into a string representation of Rhino's Undefined instance. This can in theory lead to wrong function invocations if the target type is a string. Instead, return a special undefined value with a special undefined VOID type. This prints as undefined in the console, to make it transparent what is going on. Other than that, it behaves as void. This is consistent with JS methods returning `undefined` if no value was returned, and TypeScript void methods returning `undefined`. To prevent any confusion, forbid undefined values from being passed to Ash functions (for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JS
undefinedis silently converted into a string representation of Rhino's Undefined instance.This can in theory lead to wrong function invocations if the target type is a string.
Instead, return a special undefined value with a special undefined VOID type. This prints as undefined in the console, to make it transparent what is going on.
Other than that, it behaves as void. This is consistent with JS methods returning
undefinedif no value was returned, and TypeScript void methods returningundefined.To prevent any confusion, forbid undefined values from being passed to Ash functions (for now).