Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curse scripting command #2295

Merged
merged 1 commit into from
May 12, 2024
Merged

Add curse scripting command #2295

merged 1 commit into from
May 12, 2024

Conversation

oxc
Copy link
Contributor

@oxc oxc commented May 2, 2024

It's a replacement for calling the CLI throw command that makes parameter handling more straight-forward.

@oxc oxc requested a review from a team as a code owner May 2, 2024 08:29
@gausie
Copy link
Contributor

gausie commented May 2, 2024

Can we get some unit tests for the function please

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.08%. Comparing base (b1dc7e8) to head (ac62290).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2295      +/-   ##
============================================
+ Coverage     38.07%   38.08%   +0.01%     
- Complexity    20098    20105       +7     
============================================
  Files          1113     1113              
  Lines        170782   170807      +25     
  Branches      35922    35923       +1     
============================================
+ Hits          65027    65059      +32     
+ Misses        95612    95606       -6     
+ Partials      10143    10142       -1     
Files Coverage Δ
...et/sourceforge/kolmafia/textui/RuntimeLibrary.java 48.27% <100.00%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1dc7e8...ac62290. Read the comment docs.

It's a replacement for calling the CLI throw command that makes
parameter handling more straight-forward.
@oxc
Copy link
Contributor Author

oxc commented May 12, 2024

Can we get some unit tests for the function please

I've added some tests

@midgleyc midgleyc merged commit a0ba307 into kolmafia:main May 12, 2024
5 checks passed
@oxc oxc deleted the curse branch May 12, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants