CrystalBallManager #332
CrystalBallManager #332
Conversation
|
Yeah this looks great. Can you add one FightRequest test and some tests to ckb in the forums suggested a proxy record property of turn and monster per $location, which I thought sounded like a nice idea also. |
this was there because I initially thought that any request not in adventure.php or fight.php wouldn't affect predictions It's worth noting that while that assertion ended up not being true, we'll most likely end up needing to use it again later. This is because relying on KoLAdventure.lastLocationName is error prone, because we only want to list visits to adventure.php locations, and KoLAdventure.lastLocationName currently includes locations such as cellar.php. (I guess we could also try to spot them at the start of the method...)
Doing this for most fight requests would most likely be bloat for those test files. Could there be a dedicated location to store that html? |
|
You can store the HTML wherever you want - check recent tests for gnomeAdv
…On Sun, 12 Dec 2021 at 18:15, Frederic Gagnon ***@***.***> wrote:
#318 <#318> is also waiting for
some good tests of FightRequest. I'm inclined to uses @gausie
<https://github.com/gausie>' smost recent work as a model for future
test. Basically capture the "right" html and then load it and test for the
right things to happen.
Doing this for most fight requests would most likely be bloat for those
test files. Could there be a dedicated location to store that html?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABL4LU22VKH7RAWFJI64STUQTRFJANCNFSM5J33NJ4Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
(this sure would have been a nice use for https://kolmafia.us/threads/responsemakingutilities.26848/ ... (._. ) ) |
|
I don't mind at all saving the whole HTML page. In fact on balance I'd probably rather we do so to catch weird edge cases. Unless you're talking about something else? |
|
no, that was pretty much it. |
I commented over there. My concern is a framework that is so complex that it needs its own tests. |
|
Please don't build an HTML builder |
|
All this needs now is a few |
test/net/sourceforge/kolmafia/session/CrystalBallManagerTest.java
Outdated
Show resolved
Hide resolved
|
I'll put an announcement on the forums about this pref changing and then merge this today |
Additional tests will obviously be required