Wrong check for redirect? #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaadams5
commented
Jan 15, 2022
| @@ -84,8 +84,7 @@ private static String readWikiData(String url) { | |||
| byte[] bytes = ByteBufferUtilities.read(istream); | |||
| return StringUtilities.getEncodedString(bytes, "UTF-8"); | |||
| } | |||
| // JAA - Should this be && and not || ? | |||
| if (responseCode >= 301 || responseCode < 308) { | |||
| if (301 <= responseCode && responseCode <= 308) { | |||
There was a problem hiding this comment.
Old code triggered the conditional if responseCode <= 301. So the comparison to 308 was never made. 308 is a permanent redirect and in context I think the code would want to follow it.
Veracity0
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code actually triggers for non-redirect status codes, I believe. Am I right?