Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Ronin, you can only pull one of an item #539

Merged
merged 5 commits into from Jan 26, 2022
Merged

In Ronin, you can only pull one of an item #539

merged 5 commits into from Jan 26, 2022

Conversation

Veracity0
Copy link
Contributor

This adds a new property - _roninStoragePulls - which contains the item number of each item you have pulled today while in Ronin.

Will grey that item out in the Storage panel of Inventory manager if you've already pulled one.
Huh. I should make it not visible so you can't even select it. Stay tuned.

StorageRequest will prune out all items you've already pulled today and will not attempt to pull such. Here's what that looks like:

> pull 1 jar of squeeze

You've already pulled one 'jar of squeeze' today. Skipping...
No items could be removed from storage.

When you do succeed in pulling items, the property is updated.

@Veracity0 Veracity0 requested a review from a team January 26, 2022 20:19
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #539 (7f62f36) into main (2e6a04b) will increase coverage by 0.01%.
The diff coverage is 64.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #539      +/-   ##
============================================
+ Coverage     19.57%   19.58%   +0.01%     
- Complexity     8068     8087      +19     
============================================
  Files           998      998              
  Lines        155878   155932      +54     
  Branches      34673    34684      +11     
============================================
+ Hits          30508    30543      +35     
- Misses       119686   119702      +16     
- Partials       5684     5687       +3     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/KoLmafia.java 8.07% <0.00%> (-0.01%) ⬇️
...eforge/kolmafia/swingui/panel/ItemManagePanel.java 10.41% <0.00%> (-0.11%) ⬇️
...lmafia/swingui/widget/ListCellRendererFactory.java 1.19% <0.00%> (-0.01%) ⬇️
...t/sourceforge/kolmafia/request/StorageRequest.java 16.76% <76.08%> (+9.67%) ⬆️
src/net/sourceforge/kolmafia/KoLCharacter.java 33.88% <100.00%> (+0.11%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6a04b...7f62f36. Read the comment docs.

@jaadams5
Copy link
Contributor

My experience is that it was one pull of each type per run and not per day. Can't check at the moment but maybe someone can chime in.

@Veracity0
Copy link
Contributor Author

Veracity0 commented Jan 26, 2022

I guarantee that is not true.

January 24

pull: 1 jar of squeeze
[190] The Defiled Nook
drink 1 jar of squeeze

January 25

pull: 1 jar of squeeze
[417] The Hidden Temple
drink 1 jar of squeeze

Not to mention that KoL's message if you try to pull a second one in the Relay Browser is "You already pulled one of those today." Although, I did just mention it, didn't I?

@Veracity0 Veracity0 merged commit 92d0375 into main Jan 26, 2022
@Veracity0 Veracity0 deleted the ronin-storage branch January 26, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants