Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Expression and ModifierExpression + some performance stuff #540

Merged
merged 18 commits into from
Jan 27, 2022

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Jan 26, 2022

  • Add tests for Expression and ModifierExpression
  • Fix some things that are broken (no one noticed that path() just didn't work, for example)
  • Avoid string concatenation in loops in expression
  • Do some simple performance improvements (like using isBlank() instead of comparing to a blank string)
  • Remove some unnecessary iteration by using addAll etc

@gausie gausie requested a review from a team as a code owner January 26, 2022 21:39
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #540 (e2814c7) into main (7c4de0e) will increase coverage by 0.15%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #540      +/-   ##
============================================
+ Coverage     19.60%   19.76%   +0.15%     
- Complexity     8095     8184      +89     
============================================
  Files           998      998              
  Lines        155923   155938      +15     
  Branches      34681    34670      -11     
============================================
+ Hits          30566    30817     +251     
+ Misses       119664   119454     -210     
+ Partials       5693     5667      -26     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/AreaCombatData.java 14.80% <0.00%> (-0.19%) ⬇️
src/net/sourceforge/kolmafia/CakeArenaManager.java 0.00% <0.00%> (ø)
src/net/sourceforge/kolmafia/FamiliarData.java 22.64% <0.00%> (ø)
src/net/sourceforge/kolmafia/KoLAdventure.java 15.18% <0.00%> (-0.24%) ⬇️
src/net/sourceforge/kolmafia/KoLmafia.java 8.07% <0.00%> (ø)
src/net/sourceforge/kolmafia/KoLmafiaASH.java 12.50% <0.00%> (ø)
src/net/sourceforge/kolmafia/KoLmafiaCLI.java 67.95% <0.00%> (ø)
src/net/sourceforge/kolmafia/KoLmafiaGUI.java 0.00% <0.00%> (ø)
src/net/sourceforge/kolmafia/PastaThrallData.java 50.00% <0.00%> (+8.82%) ⬆️
src/net/sourceforge/kolmafia/RequestEditorKit.java 17.93% <0.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4de0e...e2814c7. Read the comment docs.

@gausie gausie merged commit 8617659 into main Jan 27, 2022
@gausie gausie deleted the little-perf branch January 27, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants