Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing of HolidayDatabase-related functions (and add relevant tests to Modifiers) #564

Merged
merged 4 commits into from
Jan 31, 2022

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Jan 31, 2022

No description provided.

@gausie gausie requested a review from a team as a code owner January 31, 2022 12:53
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #564 (6f4e5bd) into main (7c6f78a) will increase coverage by 0.05%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #564      +/-   ##
============================================
+ Coverage     20.36%   20.41%   +0.05%     
- Complexity     8584     8613      +29     
============================================
  Files           998      998              
  Lines        155995   155995              
  Branches      34704    34703       -1     
============================================
+ Hits          31768    31847      +79     
+ Misses       118307   118222      -85     
- Partials       5920     5926       +6     
Impacted Files Coverage Δ
...rceforge/kolmafia/persistence/HolidayDatabase.java 35.07% <78.57%> (+4.78%) ⬆️
src/net/sourceforge/kolmafia/Expression.java 89.51% <100.00%> (+1.60%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️
src/net/sourceforge/kolmafia/RequestLogger.java 9.83% <0.00%> (+1.16%) ⬆️
...urceforge/kolmafia/swingui/menu/ScriptMRUList.java 52.11% <0.00%> (+1.40%) ⬆️
src/net/sourceforge/kolmafia/StaticEntity.java 20.39% <0.00%> (+4.46%) ⬆️
.../net/sourceforge/kolmafia/utilities/LogStream.java 79.16% <0.00%> (+64.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6f78a...6f4e5bd. Read the comment docs.

midgleyc
midgleyc previously approved these changes Jan 31, 2022
@gausie gausie merged commit 9656014 into main Jan 31, 2022
@gausie gausie deleted the test-holiday-stuff branch January 31, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants