Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locket fixes #587

Merged
merged 4 commits into from Feb 8, 2022
Merged

Locket fixes #587

merged 4 commits into from Feb 8, 2022

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Feb 8, 2022

Fixes a few issues with locket

  • Detecting locket fights by the frame around the monster is not good enough - sometimes it doesn't show
  • Modifier reconcilliation by string searching "Experience" picks up false positives (like "Experience (Moxie)")

@gausie gausie requested a review from a team as a code owner February 8, 2022 12:41
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #587 (30180ae) into main (41a01c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #587   +/-   ##
=========================================
  Coverage     20.92%   20.92%           
- Complexity     8943     8945    +2     
=========================================
  Files          1000     1000           
  Lines        156140   156141    +1     
  Branches      34688    34689    +1     
=========================================
+ Hits          32671    32673    +2     
+ Misses       117532   117530    -2     
- Partials       5937     5938    +1     
Impacted Files Coverage Δ
...et/sourceforge/kolmafia/session/LocketManager.java 88.88% <100.00%> (+0.17%) ⬆️
...net/sourceforge/kolmafia/request/FightRequest.java 23.78% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a01c1...30180ae. Read the comment docs.

@gausie gausie merged commit 53d4187 into main Feb 8, 2022
@gausie gausie deleted the locket-fixes branch February 8, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants