Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemFinder really can get multiple items with a pilcrow - and it aly can't handle it. #603

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

Veracity0
Copy link
Contributor

I noticed bogus messages like the following:

820728820658209 is out of range, returning 0

that is a result of:

autosell 4 ¶8207, 28 ¶8206, 5 ¶8209

I guess that batched CLI commands really can pass in a bunch of pilcrow-specified items in a single command.

Restore rejection of such and let them be split by commas and parsed individually.

@Veracity0 Veracity0 requested a review from a team as a code owner February 16, 2022 06:09
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #603 (bb69a8c) into main (27ae5da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #603   +/-   ##
=========================================
  Coverage     21.00%   21.00%           
  Complexity     9021     9021           
=========================================
  Files          1001     1001           
  Lines        156157   156161    +4     
  Branches      34709    34711    +2     
=========================================
+ Hits          32805    32806    +1     
- Misses       117416   117420    +4     
+ Partials       5936     5935    -1     
Impacted Files Coverage Δ
...t/sourceforge/kolmafia/persistence/ItemFinder.java 80.62% <100.00%> (+0.27%) ⬆️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (-0.24%) ⬇️
...ourceforge/kolmafia/utilities/StringUtilities.java 58.21% <0.00%> (-0.23%) ⬇️
...sourceforge/kolmafia/persistence/ItemDatabase.java 40.87% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ae5da...bb69a8c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant