Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mall search logger #623

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Mall search logger #623

merged 6 commits into from
Feb 22, 2022

Conversation

Veracity0
Copy link
Contributor

These:

mallsearch shop #1053259
mallsearch "black & tan"
mallsearch "tea"
mallsearch tea
mallsearch tea (page 2)
mallsearch tea (page 3)
mallsearch tea (page 4)
mallsearch category food [EPIC]
mallsearch category food [awesome, EPIC]
mallsearch category food [awesome, EPIC] (page 2)

are better than:

mall.php?didadv=1&pudnuggler=&category=food&food_sortitemsby=name&booze_sortitemsby=name&othercon_sortitemsby=name&consumable_byme=0&hats_sortitemsby=name&shirts_sortitemsby=name&pants_sortitemsby=name&weapons_sortitemsby=name&weaponattribute=3&weaponhands=3&acc_sortitemsby=name&offhand_sortitemsby=name&wearable_byme=0&famequip_sortitemsby=name&nolimits=0&justitems=0&sortresultsby=price&max_price=0&x_cheapest=0&consumable_tier_1=0&consumable_tier_2=0&consumable_tier_3=0&consumable_tier_4=0&consumable_tier_4=1&consumable_tier_5=0&consumable_tier_5=1

@Veracity0 Veracity0 requested a review from a team as a code owner February 21, 2022 21:42
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #623 (0d7c252) into main (a8af2d4) will increase coverage by 0.00%.
The diff coverage is 77.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #623   +/-   ##
=========================================
  Coverage     21.33%   21.33%           
+ Complexity     9159     9155    -4     
=========================================
  Files          1000     1000           
  Lines        156177   156235   +58     
  Branches      34714    34729   +15     
=========================================
+ Hits          33314    33329   +15     
- Misses       116781   116828   +47     
+ Partials       6082     6078    -4     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/RequestLogger.java 8.63% <0.00%> (-0.04%) ⬇️
...ourceforge/kolmafia/request/MallSearchRequest.java 45.80% <83.33%> (+6.29%) ⬆️
...t/sourceforge/kolmafia/request/GenericRequest.java 17.61% <85.71%> (+0.78%) ⬆️
...et/sourceforge/kolmafia/maximizer/CheckedItem.java 33.98% <0.00%> (-6.80%) ⬇️
...rceforge/kolmafia/swingui/menu/PartialMRUList.java 77.77% <0.00%> (-6.67%) ⬇️
...e/kolmafia/persistence/AdventureQueueDatabase.java 29.67% <0.00%> (-3.88%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 76.92% <0.00%> (-1.29%) ⬇️
...sourceforge/kolmafia/textui/langserver/Script.java 84.04% <0.00%> (-1.07%) ⬇️
...e/kolmafia/persistence/AdventureSpentDatabase.java 15.68% <0.00%> (-0.99%) ⬇️
...eforge/kolmafia/persistence/AdventureDatabase.java 50.99% <0.00%> (-0.50%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8af2d4...0d7c252. Read the comment docs.

@Veracity0 Veracity0 enabled auto-merge (squash) February 22, 2022 04:24
@Veracity0 Veracity0 merged commit f1630e4 into main Feb 22, 2022
@Veracity0 Veracity0 deleted the mall-search-logger branch February 22, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants