Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey you updates #633

Merged
merged 9 commits into from
Feb 26, 2022
Merged

Grey you updates #633

merged 9 commits into from
Feb 26, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Feb 26, 2022

10 new Grey You skills.
One skill nerfed.

Fix NPE when request desc for a skill whose category is out of range.
Add the GREY_YOU category.
Fix NPE when Genie Wish parsing fails.

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #633 (b4f095b) into main (045e401) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #633   +/-   ##
=========================================
  Coverage     21.41%   21.41%           
  Complexity     9214     9214           
=========================================
  Files           999      999           
  Lines        156164   156168    +4     
  Branches      34723    34725    +2     
=========================================
+ Hits          33445    33446    +1     
- Misses       116521   116523    +2     
- Partials       6198     6199    +1     
Impacted Files Coverage Δ
...ourceforge/kolmafia/persistence/SkillDatabase.java 26.53% <0.00%> (-0.08%) ⬇️
...net/sourceforge/kolmafia/request/GenieRequest.java 0.00% <0.00%> (ø)
...sourceforge/kolmafia/textui/langserver/Script.java 86.17% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045e401...b4f095b. Read the comment docs.

@Veracity0 Veracity0 marked this pull request as ready for review February 26, 2022 19:24
@Veracity0 Veracity0 requested a review from a team as a code owner February 26, 2022 19:24
@Veracity0 Veracity0 merged commit a8c1e07 into main Feb 26, 2022
@Veracity0 Veracity0 deleted the grey-you-updates branch February 26, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants