Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wiki requests to use Java 9 HttpClient #634

Merged
merged 4 commits into from
Feb 27, 2022

Conversation

midgleyc
Copy link
Member

Work on https://kolmafia.us/threads/migration-from-http-1-1-to-http-2-0.27303/, though less ambitious this time.

Lets us get rid of the inifinite loop and manual redirect handling.

Fix some of the wiki links for items.

Tested using checkPlurals.

@midgleyc midgleyc requested a review from a team as a code owner February 27, 2022 14:35
@codecov
Copy link

codecov bot commented Feb 27, 2022

Codecov Report

Merging #634 (9438bbe) into main (a8c1e07) will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #634      +/-   ##
============================================
- Coverage     21.41%   21.41%   -0.01%     
- Complexity     9214     9215       +1     
============================================
  Files           999      999              
  Lines        156168   156171       +3     
  Branches      34725    34724       -1     
============================================
  Hits          33445    33445              
- Misses       116524   116528       +4     
+ Partials       6199     6198       -1     
Impacted Files Coverage Δ
...ourceforge/kolmafia/persistence/DebugDatabase.java 9.96% <0.00%> (+0.01%) ⬆️
.../sourceforge/kolmafia/utilities/HttpUtilities.java 77.77% <60.00%> (-22.23%) ⬇️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c1e07...9438bbe. Read the comment docs.

@midgleyc midgleyc merged commit e039156 into kolmafia:main Feb 27, 2022
@midgleyc midgleyc deleted the http-client-wiki branch February 27, 2022 19:12
@midgleyc midgleyc added the performance Improve Mafia speed / CPU label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve Mafia speed / CPU
Projects
None yet
2 participants