Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "all" to "*" for batched take_shop #636

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

libraryaddict
Copy link
Contributor

Checking git blame, "all" has never been a valid parameter.

@libraryaddict libraryaddict requested a review from a team as a code owner February 28, 2022 08:09
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #636 (6287d54) into main (9c3c5aa) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #636      +/-   ##
============================================
- Coverage     21.40%   21.35%   -0.05%     
+ Complexity     9204     9176      -28     
============================================
  Files           999      999              
  Lines        156158   156158              
  Branches      34714    34714              
============================================
- Hits          33430    33353      -77     
- Misses       116534   116599      +65     
- Partials       6194     6206      +12     
Impacted Files Coverage Δ
...et/sourceforge/kolmafia/textui/RuntimeLibrary.java 33.20% <0.00%> (ø)
...sourceforge/kolmafia/request/SkateParkRequest.java 0.00% <0.00%> (-20.52%) ⬇️
...urceforge/kolmafia/swingui/menu/ScriptMRUList.java 43.66% <0.00%> (-7.05%) ⬇️
...sourceforge/kolmafia/textui/langserver/Script.java 78.72% <0.00%> (-6.39%) ⬇️
.../kolmafia/textui/langserver/AshLanguageServer.java 96.07% <0.00%> (-1.97%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 76.92% <0.00%> (-1.29%) ⬇️
...e/kolmafia/persistence/AdventureQueueDatabase.java 32.90% <0.00%> (-0.65%) ⬇️
.../net/sourceforge/kolmafia/maximizer/Maximizer.java 32.50% <0.00%> (-0.64%) ⬇️
...sourceforge/kolmafia/request/AdventureRequest.java 32.04% <0.00%> (-0.51%) ⬇️
src/net/sourceforge/kolmafia/FamiliarData.java 22.47% <0.00%> (-0.34%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3c5aa...6287d54. Read the comment docs.

@Veracity0 Veracity0 merged commit 82cfea9 into kolmafia:main Feb 28, 2022
@libraryaddict libraryaddict deleted the batch-take-shop branch July 25, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants