Parse stats from api.php in Grey You #640
Conversation
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
============================================
- Coverage 21.41% 21.40% -0.01%
Complexity 9205 9205
============================================
Files 999 999
Lines 156154 156166 +12
Branches 34713 34714 +1
============================================
- Hits 33433 33431 -2
- Misses 116524 116537 +13
- Partials 6197 6198 +1
Continue to review full report at Codecov.
|
| long rawmuscle = 0; | ||
| long rawmysticality = 0; | ||
| long rawmoxie = 0; | ||
| if (KoLCharacter.inGreyYou()) { |
There was a problem hiding this comment.
I initially wondered why we had to look at the static global, considering that "path" was right in the JSON, but then I realized that was our convention; when parsing the JSON from api.php, we parse it in AccountRequest first - which sets the ascension path - before CharSheetRequest and CharPaneRequest. I wish that ordering dependency was documented in ApiRequest.parseStatus.
| rawmuscle = JSON.getLong("rawmuscle"); | ||
| rawmysticality = JSON.getLong("rawmysticality"); | ||
| rawmoxie = JSON.getLong("rawmoxie"); | ||
| } | ||
|
|
||
| KoLCharacter.setStatPoints(muscle, rawmuscle, mysticality, rawmysticality, moxie, rawmoxie); |
There was a problem hiding this comment.
Seems like there could be a test in CharSheetRequestTest for this method. There are tests for parseStatus(String html), but not for parseStatus(JSONObject JSON).
There was a problem hiding this comment.
Looks like my next task is to learn how test writing works.
No description provided.