Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'gooskills' command #641

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Add 'gooskills' command #641

merged 4 commits into from
Mar 4, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Mar 4, 2022

gooskills

Will display an HTML table with all Grey You skills - name, type, which monster and zone grants it, the effect.

gooskills needed

The same as above but filters out all skills you already have.

gooskills id (default)
gooskills name
gooskills monster
gooskills zone

(You can also include 'needed' if you want).
How to sort the skills before generating the table.

I haven't actually ascended into a Grey You run yet, so haven't tested "needed".
I expect to ascend today - which is why I made this little helper.
Sort of like we have "accordions" and "latte" commands.

@Veracity0 Veracity0 requested a review from a team as a code owner March 4, 2022 17:27
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #641 (ad6019a) into main (6ac1ad6) will increase coverage by 0.01%.
The diff coverage is 24.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #641      +/-   ##
============================================
+ Coverage     21.40%   21.41%   +0.01%     
- Complexity     9204     9211       +7     
============================================
  Files           999     1000       +1     
  Lines        156166   156304     +138     
  Branches      34714    34738      +24     
============================================
+ Hits          33427    33473      +46     
- Misses       116540   116628      +88     
- Partials       6199     6203       +4     
Impacted Files Coverage Δ
...orge/kolmafia/textui/command/GooSkillsCommand.java 24.08% <24.08%> (ø)
src/net/sourceforge/kolmafia/KoLmafiaCLI.java 68.05% <100.00%> (+0.04%) ⬆️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (ø)
...sourceforge/kolmafia/session/EquipmentManager.java 22.34% <0.00%> (+0.08%) ⬆️
...ourceforge/kolmafia/persistence/SkillDatabase.java 27.69% <0.00%> (+1.16%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac1ad6...ad6019a. Read the comment docs.

midgleyc
midgleyc previously approved these changes Mar 4, 2022
@Veracity0 Veracity0 merged commit d43d9f7 into main Mar 4, 2022
@Veracity0 Veracity0 deleted the goo-skills branch March 4, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants