Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use http client in FileUtilities #645

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

midgleyc
Copy link
Member

@midgleyc midgleyc commented Mar 5, 2022

Continuation of #639.

Some changes to test classes to try to aid in writing tests, though I've not managed to get one done yet.

Found it difficult to tell when FileUtilities was being used, but I got lowercase headers from Cloudflare when requesting images, so I think probably then.

@midgleyc midgleyc requested a review from a team as a code owner March 5, 2022 22:38
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #645 (286fa9d) into main (fa03cd2) will increase coverage by 0.00%.
The diff coverage is 15.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #645   +/-   ##
=========================================
  Coverage     21.41%   21.41%           
- Complexity     9211     9212    +1     
=========================================
  Files          1000     1000           
  Lines        156306   156329   +23     
  Branches      34738    34739    +1     
=========================================
+ Hits          33475    33484    +9     
- Misses       116629   116637    +8     
- Partials       6202     6208    +6     
Impacted Files Coverage Δ
...t/sourceforge/kolmafia/request/GenericRequest.java 17.67% <0.00%> (-0.01%) ⬇️
.../sourceforge/kolmafia/utilities/FileUtilities.java 26.80% <18.36%> (+1.47%) ⬆️
.../sourceforge/kolmafia/utilities/HttpUtilities.java 77.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa03cd2...286fa9d. Read the comment docs.

@midgleyc midgleyc merged commit 70235f7 into kolmafia:main Mar 6, 2022
@midgleyc midgleyc deleted the file-utilities-http-client branch March 6, 2022 18:17
@midgleyc midgleyc added the performance Improve Mafia speed / CPU label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve Mafia speed / CPU
Projects
None yet
2 participants