tests: simplify some string utilities tests

[midgleyc]

Some comments I had on #616, implemented.

• replace char[] with String
• remove the explicit catch-failure on exceptions, and just let them be thrown to fail the test
• use List.of for expected

[codecov]

Codecov Report

Merging #658 (1bf1d0a) into main (1897d5e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #658   +/-   ##
=========================================
  Coverage     21.77%   21.77%           
  Complexity     9369     9369           
=========================================
  Files          1003     1003           
  Lines        157070   157070           
  Branches      34819    34819           
=========================================
  Hits          34208    34208           
  Misses       116590   116590           
  Partials       6272     6272           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1897d5e...1bf1d0a. Read the comment docs.

[jaadams5]

Some comments I had on #616, implemented.

• replace char[] with String

I deliberately did not do that because "your way" on my system created a failing test and reduced coverage. Since this doesn't do either of those, I must have misunderstood "your way".

• remove the explicit catch-failure on exceptions, and just let them be thrown to fail the test

I chose not to do this because I think the other implementation was easier to quickly read and understand what the test was, and was not doing, but not worth arguing over a preference.

• use List.of for expected

Whoops. I either missed some or something got lost in conflict resolution. Thanks.