Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set the HTTP referer header #661

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

midgleyc
Copy link
Member

Spun out of https://kolmafia.us/threads/getting-an-error-unable-to-log-in.27387/#post-167382

On earlier versions of Java 11 this isn't valid to do, and does no harm
to omit.

Remove code dealing with pics.communityofloathing.com, which no longer
resolves.

On earlier versions of Java 11 this isn't valid to do, and does no harm
to omit.

Remove code dealing with pics.communityofloathing.com, which no longer
resolves.
@midgleyc midgleyc requested a review from a team as a code owner March 18, 2022 17:07
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #661 (c091aff) into main (40fd12a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #661      +/-   ##
============================================
- Coverage     21.85%   21.84%   -0.01%     
+ Complexity     9411     9407       -4     
============================================
  Files          1003     1003              
  Lines        157154   157146       -8     
  Branches      34831    34829       -2     
============================================
- Hits          34339    34330       -9     
  Misses       116553   116553              
- Partials       6262     6263       +1     
Impacted Files Coverage Δ
.../sourceforge/kolmafia/utilities/FileUtilities.java 29.31% <ø> (+0.29%) ⬆️
...t/sourceforge/kolmafia/request/GenericRequest.java 21.41% <100.00%> (-0.11%) ⬇️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (-1.17%) ⬇️
...forge/kolmafia/persistence/ConcoctionDatabase.java 43.48% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fd12a...c091aff. Read the comment docs.

@midgleyc midgleyc merged commit 533ec5c into kolmafia:main Mar 18, 2022
@midgleyc midgleyc deleted the no-set-referer branch March 18, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants