Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Http Headers work #663

Merged
merged 4 commits into from
Mar 19, 2022
Merged

Further Http Headers work #663

merged 4 commits into from
Mar 19, 2022

Conversation

midgleyc
Copy link
Member

  • on a pseudo-response, the Date header had the wrong format
  • on a pseudo-response, leave it up to the browser as to whether or not to close the connection
  • log more information in case of IOException, to try to track down why that happens sometimes

@midgleyc midgleyc requested a review from a team as a code owner March 19, 2022 10:47
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #663 (6f522da) into main (533ec5c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #663      +/-   ##
============================================
- Coverage     21.84%   21.84%   -0.01%     
+ Complexity     9407     9406       -1     
============================================
  Files          1003     1003              
  Lines        157146   157146              
  Branches      34829    34830       +1     
============================================
- Hits          34330    34324       -6     
- Misses       116553   116555       +2     
- Partials       6263     6267       +4     
Impacted Files Coverage Δ
...t/sourceforge/kolmafia/request/GenericRequest.java 21.37% <0.00%> (-0.05%) ⬇️
...net/sourceforge/kolmafia/request/RelayRequest.java 5.19% <0.00%> (+<0.01%) ⬆️
src/net/sourceforge/kolmafia/webui/RelayAgent.java 0.00% <0.00%> (ø)
...sourceforge/kolmafia/textui/langserver/Script.java 81.91% <0.00%> (-3.20%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 44.31% <0.00%> (-0.13%) ⬇️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533ec5c...6f522da. Read the comment docs.

@midgleyc midgleyc merged commit 02e2022 into kolmafia:main Mar 19, 2022
@midgleyc midgleyc deleted the http-headers branch March 19, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants