More StringUtils Testing #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #664 +/- ##
============================================
+ Coverage 21.84% 21.88% +0.04%
- Complexity 9406 9444 +38
============================================
Files 1003 1003
Lines 157146 157148 +2
Branches 34830 34830
============================================
+ Hits 34327 34392 +65
+ Misses 116553 116509 -44
+ Partials 6266 6247 -19
Continue to review full report at Codecov.
|
midgleyc
approved these changes
Mar 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests for StringUtilities. I'm basically looking at the coverage report and trying to make the red (uncovered) disappear :-) There is one probable bug in the code but I chose not to fix it right now. Basically the test creates an overflow situation but the code doesn't detect it and return 0 as it does for other overflows. Deferred to the next commit in case someone has a different opinion on the behaviour.
After this is merged I'll continue towards 100%. If there are good refactoring tools that might put the tests in a more coherent order, I'd love to know about them. Similarly if there is a way to get a coverage report from just running the tests in one file that would be interesting. Much of the coverage comes from static initialization code triggered by other tests.