Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore pseudo-headers #667

Merged
merged 2 commits into from
Mar 20, 2022
Merged

Conversation

midgleyc
Copy link
Member

HTTP/2 requests made under HttpClient may return pseudo-headers (e.g. ":status", ":version").

When proxying headers from KoL, don't include these headers.

@midgleyc midgleyc requested a review from a team as a code owner March 20, 2022 09:14
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #667 (91446cb) into main (5582efc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #667      +/-   ##
============================================
- Coverage     22.01%   22.01%   -0.01%     
  Complexity     9515     9515              
============================================
  Files          1003     1003              
  Lines        157194   157196       +2     
  Branches      34831    34832       +1     
============================================
  Hits          34614    34614              
- Misses       116305   116307       +2     
  Partials       6275     6275              
Impacted Files Coverage Δ
...net/sourceforge/kolmafia/request/RelayRequest.java 17.45% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5582efc...91446cb. Read the comment docs.

@midgleyc midgleyc enabled auto-merge (squash) March 20, 2022 09:48
@jaadams5 jaadams5 disabled auto-merge March 20, 2022 12:35
@jaadams5 jaadams5 merged commit 4a9dcc2 into kolmafia:main Mar 20, 2022
@midgleyc midgleyc deleted the ignore-pseudo-headers branch March 20, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants