Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry transient IOExceptions on requests #668

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

midgleyc
Copy link
Member

Detect, by error message, certain errors as transient and treat them as timeouts.

Related to https://kolmafia.us/threads/ioexception-goaway-received.27397/.

Detect, by error message, certain errors as transient and treat them as timeouts.
@midgleyc midgleyc requested a review from a team as a code owner March 20, 2022 14:21
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #668 (b155c2e) into main (4a9dcc2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #668      +/-   ##
============================================
- Coverage     22.01%   22.01%   -0.01%     
  Complexity     9515     9515              
============================================
  Files          1003     1003              
  Lines        157196   157202       +6     
  Branches      34832    34836       +4     
============================================
  Hits          34614    34614              
- Misses       116307   116313       +6     
  Partials       6275     6275              
Impacted Files Coverage Δ
...t/sourceforge/kolmafia/request/GenericRequest.java 20.86% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9dcc2...b155c2e. Read the comment docs.

@midgleyc midgleyc merged commit 7dc1a52 into kolmafia:main Mar 20, 2022
@midgleyc midgleyc deleted the retry-transient-ioexception branch March 20, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants