Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for dynamic choice options for the Unknown Tomb #669

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

Veracity0
Copy link
Contributor

On the Nemesis Quest, the first task is to retrieve your Epic Weapon from the Tomb of the Unknown CLASS.
You adventure in the Unquiet Garves until you encounter the tomb.
On the door is a riddle with three (class-specific) answers.
The order of the answers (i.e. the choice option #) is shuffled every time you refresh the page.
ChoiceManager has special handling for automating this choice to choose the (currently) correct option.

This test has three saved HTML files with the correct answer in option 1, option 2, and option 3.
It verifies that we pick the correct option in each case.

@Veracity0 Veracity0 requested a review from a team as a code owner March 20, 2022 16:11
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #669 (a5f333d) into main (7dc1a52) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #669      +/-   ##
============================================
+ Coverage     22.01%   22.03%   +0.01%     
- Complexity     9515     9520       +5     
============================================
  Files          1003     1003              
  Lines        157202   157202              
  Branches      34836    34836              
============================================
+ Hits          34614    34636      +22     
+ Misses       116313   116280      -33     
- Partials       6275     6286      +11     
Impacted Files Coverage Δ
...et/sourceforge/kolmafia/session/ChoiceManager.java 5.32% <ø> (+0.08%) ⬆️
...ourceforge/kolmafia/utilities/ChoiceUtilities.java 12.58% <0.00%> (+5.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc1a52...a5f333d. Read the comment docs.

@Veracity0 Veracity0 merged commit 06440b0 into main Mar 20, 2022
@Veracity0 Veracity0 deleted the choice-manager-tests branch March 20, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants