StringUtils coverage #681
Merged
StringUtils coverage #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 4194cb4 Author: Veracity0 <83725298+Veracity0@users.noreply.github.com> Date: Wed Mar 23 11:28:16 2022 -0400 add pulverization for 2021 and 2022 Standard awards (#673) commit 1fe77c7 Author: Veracity0 <83725298+Veracity0@users.noreply.github.com> Date: Wed Mar 23 09:02:19 2022 -0400 rationalize availableCombatSkills (#672) * rationalize availableCombatSkills * address code review comments commit c230f53 Author: Veracity0 <83725298+Veracity0@users.noreply.github.com> Date: Tue Mar 22 14:33:10 2022 -0400 Initial support Grey Goose and combat skills (#671) * Initial support Grey Goose and combat skills * add tests * address code review comments * one last code review comment commit e491620 Author: BadHorseMonkey <58645293+BadHorseMonkey@users.noreply.github.com> Date: Mon Mar 21 20:54:36 2022 -0500 Added condition for Goblin water only finishing the quest during Heavy Rains. (#665) Co-authored-by: Jamie Adams <82782908+jaadams5@users.noreply.github.com> commit 85c33e6 Author: Veracity0 <83725298+Veracity0@users.noreply.github.com> Date: Mon Mar 21 15:48:14 2022 -0400 rationalize data types in Concoction and ConcoctionDatabase (#670)
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
============================================
+ Coverage 22.31% 22.35% +0.03%
- Complexity 9658 9684 +26
============================================
Files 1004 1004
Lines 157641 157641
Branches 34878 34878
============================================
+ Hits 35184 35238 +54
+ Misses 116148 116114 -34
+ Partials 6309 6289 -20
Continue to review full report at Codecov.
|
midgleyc
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes bring the test coverage of StringUtilities to 100%.
It should be noted that much of StringUtilities coverage comes from static initializations in other tests so many of these tests just get edge cases such as null input.