Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create '_robortDrops' pref to track number of robortender booze/mixer drops in a day #710

Merged
merged 6 commits into from
Apr 13, 2022

Conversation

lewismd13
Copy link
Contributor

By popular demand in the ASScord, this pref tracks the number of times your robortender drops a special mixer, base booze, or basic mixer. Spading suggests that all three affect the drop rate, so this pref will allow scripters to go for more valuable drops when the probability is higher.

It's in FightRequest.java as opposed to ResultProcessor.java, which would have been my preference, because of the need to listen for the drop messages for the base booze and mixers.

This is my first kolmafia PR, so I am more than open to suggestions, critique, etc. I will shortly be making a feature thread in the forums for the same.

@lewismd13 lewismd13 requested a review from a team as a code owner April 13, 2022 20:31
Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is on the preference name: can it be either _roboDrops (similar to the already existing _roboDrinks) or _robortenderDrops (so as to not cut the familiar name off in the middle)? Probably the first is better for consistency.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #710 (64b6622) into main (1a5f4f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #710   +/-   ##
=========================================
  Coverage     22.67%   22.68%           
- Complexity     9927     9936    +9     
=========================================
  Files          1006     1006           
  Lines        157965   157971    +6     
  Branches      34928    34930    +2     
=========================================
+ Hits          35820    35837   +17     
+ Misses       115815   115808    -7     
+ Partials       6330     6326    -4     
Impacted Files Coverage Δ
...net/sourceforge/kolmafia/request/FightRequest.java 25.38% <100.00%> (+0.13%) ⬆️
src/net/sourceforge/kolmafia/KoLCharacter.java 45.08% <0.00%> (-0.09%) ⬇️
src/net/sourceforge/kolmafia/Modifiers.java 59.27% <0.00%> (+0.05%) ⬆️
src/net/sourceforge/kolmafia/AdventureResult.java 43.25% <0.00%> (+0.32%) ⬆️
.../sourceforge/kolmafia/session/ResultProcessor.java 18.13% <0.00%> (+0.34%) ⬆️
...ceforge/kolmafia/persistence/FamiliarDatabase.java 38.54% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5f4f2...64b6622. Read the comment docs.

@lewismd13
Copy link
Contributor Author

My only comment is on the preference name: can it be either _roboDrops (similar to the already existing _roboDrinks) or _robortenderDrops (so as to not cut the familiar name off in the middle)? Probably the first is better for consistency.

Fair point! I have now made that change.

@midgleyc midgleyc enabled auto-merge (squash) April 13, 2022 21:24
@midgleyc midgleyc merged commit e2161dc into kolmafia:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants