Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Combat Rate case insensitive #717

Merged
merged 4 commits into from Apr 20, 2022

Conversation

horrible-little-slime
Copy link
Contributor

Right now, numericModifier("Combat Rate") and numericModifier("combat rate") return different values when you're past the cap of 25, because we only are special casing the input "Combat Rate".

@horrible-little-slime horrible-little-slime requested a review from a team as a code owner April 20, 2022 06:23
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #717 (b663db9) into main (e5305d5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b663db9 differs from pull request most recent head 1636470. Consider uploading reports for the commit 1636470 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #717   +/-   ##
=========================================
  Coverage     22.89%   22.89%           
  Complexity    10055    10055           
=========================================
  Files          1011     1011           
  Lines        158064   158064           
  Branches      34934    34934           
=========================================
  Hits          36185    36185           
  Misses       115492   115492           
  Partials       6387     6387           
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/Modifiers.java 59.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4ceed...1636470. Read the comment docs.

@jaadams5 jaadams5 merged commit 4192d3d into kolmafia:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants