fix: only retry if it's safe, even on GOAWAY #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
=========================================
Coverage 23.23% 23.23%
Complexity 10274 10274
=========================================
Files 1010 1010
Lines 158005 158005
Branches 34935 34935
=========================================
Hits 36714 36714
Misses 114702 114702
Partials 6589 6589
Continue to review full report at Codecov.
|
heeheehee-kolmafia
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, I thought GOAWAY meant that the request wasn't handled at all, but someone on Discord reported accidentally hitting the Chateau twice after the HTTP2 move. While I can't be sure this is GOAWAY, it's safer to only retry if it's safe to do so.