Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track mayday deliveries #774

Merged
merged 5 commits into from
May 26, 2022
Merged

Track mayday deliveries #774

merged 5 commits into from
May 26, 2022

Conversation

libraryaddict
Copy link
Contributor

Untested but unlikely to have issues

@libraryaddict libraryaddict requested a review from a team as a code owner May 25, 2022 01:47
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #774 (ba9a3cc) into main (47977ad) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #774      +/-   ##
============================================
- Coverage     24.54%   24.54%   -0.01%     
- Complexity    10903    10905       +2     
============================================
  Files          1016     1016              
  Lines        158822   158824       +2     
  Branches      34983    34984       +1     
============================================
  Hits          38982    38982              
+ Misses       112828   112826       -2     
- Partials       7012     7016       +4     
Impacted Files Coverage Δ
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
.../sourceforge/kolmafia/session/ResultProcessor.java 20.53% <50.00%> (+0.04%) ⬆️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (-0.47%) ⬇️
...net/sourceforge/kolmafia/session/QuestManager.java 27.42% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47977ad...ba9a3cc. Read the comment docs.

jaadams5
jaadams5 previously approved these changes May 25, 2022
Copy link
Contributor

@jaadams5 jaadams5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't suppose you'd consider grabbing some HTML and writing a test, would you?

@libraryaddict
Copy link
Contributor Author

I can sure

@midgleyc midgleyc merged commit 81d925f into kolmafia:main May 26, 2022
@libraryaddict libraryaddict deleted the mayday-track branch July 14, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants