Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can have nulls in an array of Options #790

Merged
merged 1 commit into from Jun 1, 2022

Conversation

Veracity0
Copy link
Contributor

For example, in ChoiceAdventures.dynamicChoiceOptions:

      case 781:
        // Earthbound and Down
        result = new Option[6];
        result[0] = new Option("Unlock Hidden Apartment Building");
        result[1] = new Option("Get stone triangle");
        result[2] = new Option("Get Blessing of Bulbazinalli");
        result[5] = SKIP_ADVENTURE;
        return result;

@Veracity0 Veracity0 requested a review from a team as a code owner June 1, 2022 00:15
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #790 (c850e16) into main (dff42ab) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #790   +/-   ##
=========================================
  Coverage     24.56%   24.56%           
  Complexity    10913    10913           
=========================================
  Files          1016     1016           
  Lines        158931   158931           
  Branches      35003    35003           
=========================================
  Hits          39045    39045           
  Misses       112852   112852           
  Partials       7034     7034           
Impacted Files Coverage Δ
...sourceforge/kolmafia/session/ChoiceAdventures.java 30.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff42ab...c850e16. Read the comment docs.

Copy link
Member

@midgleyc midgleyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nicer this being a map given the array can have gaps but this is a good fix.

@Veracity0
Copy link
Contributor Author

Veracity0 commented Jun 1, 2022

Agreed, but that's another stage of refactoring. This will fix an open Bug Report.

@Veracity0 Veracity0 merged commit 0080ad0 into main Jun 1, 2022
@Veracity0 Veracity0 deleted the available-choice-options branch June 1, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants