Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUFFED_HP and BUFFED_MP have a different formula in Grey You #791

Merged
merged 7 commits into from Jun 1, 2022

Conversation

Veracity0
Copy link
Contributor

Per Kasekopf's report in kolmafia.us, on the Grey You path:

  • your maximum HP and MP start with a particular value
  • they improve by absorbing certain monsters and consumables
  • they are unaffected by Muscle or Mysticality
  • the only enchantments that affect them are +HP or +MP; no percentages or stats improvements

@Veracity0 Veracity0 requested a review from a team as a code owner June 1, 2022 18:20
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #791 (8c59380) into main (e557e7e) will increase coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #791   +/-   ##
=========================================
  Coverage     24.57%   24.58%           
- Complexity    10916    10924    +8     
=========================================
  Files          1016     1016           
  Lines        158937   158947   +10     
  Branches      35004    35006    +2     
=========================================
+ Hits          39056    39071   +15     
+ Misses       112844   112842    -2     
+ Partials       7037     7034    -3     
Impacted Files Coverage Δ
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
src/net/sourceforge/kolmafia/Modifiers.java 60.01% <94.11%> (+0.33%) ⬆️
src/net/sourceforge/kolmafia/KoLCharacter.java 48.44% <100.00%> (+0.06%) ⬆️
...sourceforge/kolmafia/session/EquipmentManager.java 28.58% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e557e7e...8c59380. Read the comment docs.

@midgleyc midgleyc enabled auto-merge (squash) June 1, 2022 22:34
@midgleyc midgleyc merged commit 91dc6ca into main Jun 1, 2022
@midgleyc midgleyc deleted the modifiers-predict-fix branch June 1, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants