Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check wiki monster ids and pages #812

Merged
merged 3 commits into from Jun 11, 2022

Conversation

midgleyc
Copy link
Member

Add a checkwikimonsters command that checks pages on the wiki exist and have the same ids as Mafia thinks they should. Old ids presumably came from the Twitch streams when the monster ids were visible, player dev communication, or still being able to fight an old monster after the ids were added to the HTML.

Some monsters changed name as part of this. Generally, I changed Mafia's name only when I was pretty sure Mafia's name was wrong:

  • QuickBASIC Elemental -> QuickBASIC elemental
  • snakefire in the grass -> snakefire in the grassfire
  • Tio Cadáver -> Tío Cadáver

@midgleyc midgleyc requested a review from a team as a code owner June 11, 2022 12:10
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #812 (5813d27) into main (66e84f7) will decrease coverage by 0.00%.
The diff coverage is 15.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #812      +/-   ##
============================================
- Coverage     25.13%   25.13%   -0.01%     
  Complexity    11394    11394              
============================================
  Files          1017     1017              
  Lines        159333   159364      +31     
  Branches      35055    35066      +11     
============================================
+ Hits          40046    40049       +3     
- Misses       111856   111879      +23     
- Partials       7431     7436       +5     
Impacted Files Coverage Δ
...orge/kolmafia/textui/command/CheckDataCommand.java 4.83% <0.00%> (-0.17%) ⬇️
...ourceforge/kolmafia/persistence/DebugDatabase.java 9.89% <5.00%> (-0.06%) ⬇️
.../sourceforge/kolmafia/utilities/WikiUtilities.java 54.94% <37.50%> (-2.71%) ⬇️
src/net/sourceforge/kolmafia/KoLmafiaCLI.java 68.20% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e84f7...5813d27. Read the comment docs.

Copy link
Contributor

@Veracity0 Veracity0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting to get all those monster ids!

src/data/monsters.txt Show resolved Hide resolved
@midgleyc midgleyc enabled auto-merge (squash) June 11, 2022 15:52
@midgleyc midgleyc merged commit ecc8c0a into kolmafia:main Jun 11, 2022
@midgleyc midgleyc deleted the check-wiki-monster-ids branch June 11, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants