Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All 9 June cleaver choices are now configurable in GUI #819

Merged
merged 1 commit into from Jun 16, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Jun 15, 2022

There's a query on kolmafia.us about how the June cleaver choice adventures stop automation and there is no way to configure them. Somebody responded by instructing them to figure out which choice adventures they are, what the various options do, and then to manually set properties in the gCLI.

We considered making those configurable, but you are required to put a default into defaults.txt.
We punted on that since there is not an obvious "best default".

There are two possibilities.

Default of 4 means "skip this choice". If we choose that, you can automate right out the box without having to think about what you want. But you will miss a lot of free stats/adventures/meat/items.

Default of 0 means "show in browser". (You don't actually have to do that; you can do "choice X" in the gCLI to submit the choice.) This will stop automation, but it will remind you that maybe you want to configure June cleaver choices. You can do that, get out of the choice (browser or gCLI "choice" command), and restart automation.

I decided that default of 0 is better. It will force you - once - to set the choices to suit your tastes, rather than simply getting nothing. Heck, you may choose to set (some) of the adventures to "Do Nothing" since you only want to react to others. But that will be the user's decision.

@Veracity0 Veracity0 requested a review from a team as a code owner June 15, 2022 17:46
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #819 (bb6ae83) into main (f166e00) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #819      +/-   ##
============================================
- Coverage     25.24%   25.24%   -0.01%     
  Complexity    11484    11484              
============================================
  Files          1019     1019              
  Lines        159585   159585              
  Branches      35141    35141              
============================================
- Hits          40288    40286       -2     
+ Misses       111793   111792       -1     
- Partials       7504     7507       +3     
Impacted Files Coverage Δ
...sourceforge/kolmafia/session/ChoiceAdventures.java 30.95% <100.00%> (ø)
...sourceforge/kolmafia/textui/langserver/Script.java 85.10% <0.00%> (-2.13%) ⬇️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f166e00...bb6ae83. Read the comment docs.

@Veracity0 Veracity0 merged commit 5115fa7 into main Jun 16, 2022
@Veracity0 Veracity0 deleted the june-spoilers branch June 16, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants