Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equipped survival knife while Ultrahydrated gives +2 desert exploration #836

Merged
merged 2 commits into from Jun 30, 2022

Conversation

Veracity0
Copy link
Contributor

I decided to give Quantum Terrarium a go.

Today, the May-Day package had a survival knife and a Melodramedary appeared at my side after I had unlocked the desert and bought a UV-resistant compass. :)

I got a response text at the end of a battle where all three of those kicked in, giving me +5 Desert exploration.

@Veracity0 Veracity0 requested a review from a team as a code owner June 30, 2022 17:29
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #836 (cd166d9) into main (d00eef0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #836      +/-   ##
============================================
+ Coverage     25.49%   25.50%   +0.01%     
- Complexity    11674    11682       +8     
============================================
  Files          1019     1019              
  Lines        159476   159479       +3     
  Branches      35166    35168       +2     
============================================
+ Hits          40655    40672      +17     
+ Misses       111156   111140      -16     
- Partials       7665     7667       +2     
Impacted Files Coverage Δ
...et/sourceforge/kolmafia/objectpool/EffectPool.java 100.00% <ø> (ø)
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
...net/sourceforge/kolmafia/session/QuestManager.java 28.72% <100.00%> (+1.10%) ⬆️
...forge/kolmafia/textui/langserver/FilesMonitor.java 76.92% <0.00%> (-1.29%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 48.76% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00eef0...cd166d9. Read the comment docs.

Copy link
Contributor

@gausie gausie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It's a little weird to test all the different combinations with a test file that says "Desert Exploration increased by 5%" in it. Makes me think that we want to add a warning if our calculation doesn't match the number we get from KoL.

@Veracity0
Copy link
Contributor Author

Whoah. Hardcore auto pulls all of your IoTMs when you are out of Standard. Powdered gold for adventures via spleen and the Melodramedary were lucky, but other than that, I mostly ignored my familiar. I freed the king with full organs and 10 turns left on day 2 - including opening the volcanic island for the nemesis quest.

When doing this calculation, the only thing we look at the response text for is to see if it mentions "Desert Exploration", since, apparently, clingy monsters do not advance exploration.

Printing a warning would let us detect new things that we don't support yet. Like the survival knife, before this PR.

Perhaps next run I will collect more response texts for the various other options and we can use them in these tests - and additional tests for the warning.

@Veracity0 Veracity0 merged commit 34aead7 into main Jun 30, 2022
@Veracity0 Veracity0 deleted the survival-knife branch June 30, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants