Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Steal Accordion stationary button. More familiar weight improvements #857

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

Veracity0
Copy link
Contributor

  1. I added a "steal accordion" button to the Stationary Buttons. It is only present (and enabled) if you are an accordion thief and KoL offers you the opportunity to use that skill for a particular combat. I.e., it will not be there if the monster either doesn't have an accordion to steal or you've already stolen one today.
  2. When we "fix" a monster's weight, also set the experience to the minimum required for that level. That may not be correct, but you can see progress towards next pound, at least.
  3. If we parse equipment before charpane (as originally), we can use it for modified experience without having to manually set it in tests.
  4. Don't add an item to the familiar item slot that the familiar can't actually equip. Quantum Terrarium does this for crimbo ghosts...

@Veracity0 Veracity0 requested a review from a team as a code owner July 5, 2022 17:48
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #857 (c44e047) into main (2e6ebf2) will increase coverage by 0.00%.
The diff coverage is 56.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #857   +/-   ##
=========================================
  Coverage     25.73%   25.73%           
- Complexity    11825    11831    +6     
=========================================
  Files          1019     1019           
  Lines        159620   159626    +6     
  Branches      35192    35194    +2     
=========================================
+ Hits          41074    41081    +7     
+ Misses       110803   110800    -3     
- Partials       7743     7745    +2     
Impacted Files Coverage Δ
src/net/sourceforge/kolmafia/KoLmafia.java 10.76% <0.00%> (+0.01%) ⬆️
...orge/kolmafia/webui/StationaryButtonDecorator.java 48.48% <20.00%> (-0.33%) ⬇️
.../sourceforge/kolmafia/request/CharPaneRequest.java 48.24% <85.71%> (+0.05%) ⬆️
src/net/sourceforge/kolmafia/FamiliarData.java 40.63% <100.00%> (+0.48%) ⬆️
...c/net/sourceforge/kolmafia/request/ApiRequest.java 56.09% <100.00%> (+0.26%) ⬆️
...sourceforge/kolmafia/session/EquipmentManager.java 30.05% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6ebf2...c44e047. Read the comment docs.

@Veracity0 Veracity0 merged commit 558d758 into main Jul 5, 2022
@Veracity0 Veracity0 deleted the more-familiar-data branch July 5, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants