Correctly report last location if you multifight from an itemMonster #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Also, combats from choices are itemMonsters
midgleyc
approved these changes
Jul 11, 2022
|
I didn't see this until it was already approved and merged, but I will point out that all of your new tests are named something like this: A "mutli-fight" is a new concept. :) |
What do you mean? I named it after |
|
Look more closely at the spelling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tired of seeing
[1234] nullwhen I run a relativity fight from a Combat Lover's Locket fight - i.e. a fight without a location.We have an existing infrastructure for these fights that are triggered without visiting a location.
itemMonstermight not be the best name for it really its there for handling locationless fights, so let's make sure we use it for some of the newer sources of those.