-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directly upload Mac / Windows executables. #93
Directly upload Mac / Windows executables. #93
Commits on Oct 5, 2021
-
This creates a binary in build/KoLmafia/bin/KoLmafia. This change also adds a pruneBin task which is always run. I tried to figure out how to set up inputs / outputs, but jpackage insists on creating the output directory itself and will generate an error if said directory already exists. Follow-up changes will involve tinkering with a build matrix and looking at the resulting artifacts.
Configuration menu - View commit details
-
Copy full SHA for 7689203 - Browse repository at this point
Copy the full SHA 7689203View commit details -
Copy-paste build to run ./gradlew bin.
I'm not actually sure what the resulting files will look like on Windows / Mac, so here's to hoping I can actually see the artifacts before trying to publish them.
Configuration menu - View commit details
-
Copy full SHA for 08aa16c - Browse repository at this point
Copy the full SHA 08aa16cView commit details -
Run build for the jpackage branch.
This will allow for more experimentation without pushing to main.
Configuration menu - View commit details
-
Copy full SHA for 13fa65c - Browse repository at this point
Copy the full SHA 13fa65cView commit details -
Hopefully Mac artifacts end in dmg, and Windows artifacts end in exe. But maybe not...
Configuration menu - View commit details
-
Copy full SHA for 1685926 - Browse repository at this point
Copy the full SHA 1685926View commit details -
Apparently Mac didn't create build/KoLmafia/bin.
Configuration menu - View commit details
-
Copy full SHA for 09c6e49 - Browse repository at this point
Copy the full SHA 09c6e49View commit details -
Still not seeing the output of Mac builds, although I now see: - Linux: ${dist}/KoLmafia/bin/KoLmafia - Windows: ${dist}/KoLmafia/KoLmafia.exe Perhaps if I'm lucky, Mac is directly in ${dist}/KoLmafia.dmg? If I'm unlucky, it won't be present at all. :(
Configuration menu - View commit details
-
Copy full SHA for 16b7a19 - Browse repository at this point
Copy the full SHA 16b7a19View commit details -
This caused a nasty bit of infinite recursion. Whoops. Let's instead move things into build/bin.
Configuration menu - View commit details
-
Copy full SHA for 288ec30 - Browse repository at this point
Copy the full SHA 288ec30View commit details -
Upload all artifacts, then download them.
This allows us to get all of the artifacts in one single container so we can theoretically publish them all at once later.
Configuration menu - View commit details
-
Copy full SHA for f0d3f9a - Browse repository at this point
Copy the full SHA f0d3f9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d80c89e - Browse repository at this point
Copy the full SHA d80c89eView commit details -
We actually need everything in the generated directory, not just the runner binary.
Configuration menu - View commit details
-
Copy full SHA for dc41fee - Browse repository at this point
Copy the full SHA dc41feeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7632aec - Browse repository at this point
Copy the full SHA 7632aecView commit details -
Move code into build/releases, stop using wildcard.
This attempted to save maybe one level of directory nesting, which I don't think actually matters in practice.
Configuration menu - View commit details
-
Copy full SHA for 9fcaf5c - Browse repository at this point
Copy the full SHA 9fcaf5cView commit details -
This splits the existing daily job into two targets: jar and release. `release` in turn depends on both `jar` and `bin`. 'bin' generates files Windows.zip, Linux.zip, and macOS.zip.
Configuration menu - View commit details
-
Copy full SHA for c3d27f4 - Browse repository at this point
Copy the full SHA c3d27f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17b1c2f - Browse repository at this point
Copy the full SHA 17b1c2fView commit details -
Use jpackage-gradle-plugin instead of exec task.
It doesn't feel appreciably different, but maybe it's more readable.
Configuration menu - View commit details
-
Copy full SHA for 8f440ae - Browse repository at this point
Copy the full SHA 8f440aeView commit details -
Improve portability of jpackage task.
Mac creates the directory `build/releases/KoLmafia.app`, whereas Linux / Windows create `build/releases/KoLmafia`. jpackage will create all prerequisite directories, so it's fine with either deleting the inner directory, or its parent.
Configuration menu - View commit details
-
Copy full SHA for c78f9a0 - Browse repository at this point
Copy the full SHA c78f9a0View commit details
Commits on Oct 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8737dfa - Browse repository at this point
Copy the full SHA 8737dfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54a72b3 - Browse repository at this point
Copy the full SHA 54a72b3View commit details -
Add Windows icon for binary release.
This uses the existing martini glass that was the KoLmelion icon once upon a time.
Configuration menu - View commit details
-
Copy full SHA for f33d2c8 - Browse repository at this point
Copy the full SHA f33d2c8View commit details -
Directly upload Mac, Windows executables.
Currently, we're generating macOS.zip, Windows.zip which each only contain a single file. This change also cleans up jarbundler / jsmooth utils now that we're using + relying on jpackage for creating platform-specific builds. We also reuse the Windows icon for Linux (and rename it to get rid of the legacy KoLmelion name), which is copied into util/linux to preempt confusion along the lines of "why are we using this windows/ file in the linux build".
Configuration menu - View commit details
-
Copy full SHA for 16a22f9 - Browse repository at this point
Copy the full SHA 16a22f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ce4f7f - Browse repository at this point
Copy the full SHA 3ce4f7fView commit details -
Merge remote-tracking branch 'origin/jpackage' into jpackage
# Conflicts: # .github/workflows/build.yml # build.gradle
Configuration menu - View commit details
-
Copy full SHA for dab1b26 - Browse repository at this point
Copy the full SHA dab1b26View commit details -
Try to target deb or rpm on Linux if available.
This detects the existence of commands in the $PATH using the Bash `which` command. This also bumps our required version to Java 11 because I didn't want to pollute the build output, or roll my own NullOutputStream.
Configuration menu - View commit details
-
Copy full SHA for 0b273fb - Browse repository at this point
Copy the full SHA 0b273fbView commit details -
Add revision info to appName, appVersion.
This might be redundant, but it seemed okay in Linux. This change also replaces instances of " with ' for strings that didn't use templating.
Configuration menu - View commit details
-
Copy full SHA for ae73f15 - Browse repository at this point
Copy the full SHA ae73f15View commit details
Commits on Oct 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3fddcae - Browse repository at this point
Copy the full SHA 3fddcaeView commit details -
This change adds the Windows DirChooser, Shortcut, and useCWDasROOT f…
…lag and also the Mac switches from pkg to dmg.
Configuration menu - View commit details
-
Copy full SHA for 37540e8 - Browse repository at this point
Copy the full SHA 37540e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33c6a29 - Browse repository at this point
Copy the full SHA 33c6a29View commit details