-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the CMC command #959
Conversation
… prediction logic accordingly. Accounted for unknown locations. Added line breaks to predictions. Added more tests. Removed unused constant.
@jaadams5 I thought new state was appended to the left, not the right. I've changed the logic accordingly (it actually made it simpler). Sorry. |
Codecov Report
@@ Coverage Diff @@
## main #959 +/- ##
============================================
- Coverage 27.11% 27.11% -0.01%
+ Complexity 12697 12696 -1
============================================
Files 1029 1029
Lines 160332 160336 +4
Branches 35274 35275 +1
============================================
- Hits 43480 43478 -2
- Misses 108918 108919 +1
- Partials 7934 7939 +5
Continue to review full report at Codecov.
|
test/net/sourceforge/kolmafia/textui/command/ColdMedicineCabinetCommandTest.java
Outdated
Show resolved
Hide resolved
I think it would be good to put this functionality behind a param. Like |
Added separate command for pills.
src/net/sourceforge/kolmafia/textui/command/ColdMedicineCabinetCommand.java
Outdated
Show resolved
Hide resolved
src/net/sourceforge/kolmafia/textui/command/ColdMedicineCabinetCommand.java
Show resolved
Hide resolved
test/net/sourceforge/kolmafia/textui/command/ColdMedicineCabinetCommandTest.java
Show resolved
Hide resolved
@jaadams5 please don't merge the branch while people are working on it |
Changed pills command to plan
Looks fantastic! All we need now is a little bit of inline documentation on what the nature of some of the more complex functions are actually doing - this is quite complex and it would be good for someone coming back for maintenance in the future. |
Moved output out of populateNaiveTurnsRequiredForPillMap Handled case where there is already a majority
@jaadams5 This is now complete and ready for review/merge. :) |
Newly visited locations are appended to the right; rectified the pill prediction logic accordingly.
Accounted for unknown locations.
Added line breaks to predictions.
Added more tests.
Removed unused constant.