No NPE in can_adventure() in Standard for non-item zone #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which is a bug I just noticed.
I wrote a test for it and fixed it.
Other things:
can_adventure(location)
, which is validate1, now we have ASHprepare_for_adventure(location)
which is validate2.The following are (easy) things I am hoping to get in, but the bug is serious enough we shouldn't necessarily wait.
I can easily start yet another PR.
Throne Room:
PFA:
Isle War:
Pirate:
Disguise zones:
Bat Hole:
McLarge Huge (and Shrouded Peak):
Investigating a Plaintive Telegram: