Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deprecated adventure names to be used as synonyms #963

Merged
merged 2 commits into from Aug 9, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Aug 9, 2022

Rather than outright breaking existing ASH scripts, give them "friendly warnings"

> ash $location[Hippy Camp (Hippy Disguise)].id

Returned: 65

> ash $location[Hippy Camp in Disguise].id

Changing "Hippy Camp in Disguise" to "Hippy Camp (Hippy Disguise)" would get rid of this message. (char 11 to char 33)
Returned: 65

> ash $location[Frat House (Frat Disguise)].id

Returned: 29

> ash $location[Frat House in Disguise].id

Changing "Frat House in Disguise" to "Frat House (Frat Disguise)" would get rid of this message. (char 11 to char 33)
Returned: 29

> ash $location[The Junkyard].id

Returned: 154

> ash $location[Post-War Junkyard].id

Changing "Post-War Junkyard" to "The Junkyard" would get rid of this message. (char 11 to char 28)
Returned: 154

@Veracity0 Veracity0 requested a review from a team as a code owner August 9, 2022 15:03
Copy link
Contributor

@gausie gausie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable - there are also some breakages from zone name changes but they're harder to change since they're just pulled as strings and compared

Very friebdly indeed!

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #963 (30a4ce3) into main (d08fe01) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #963   +/-   ##
=========================================
  Coverage     27.11%   27.11%           
  Complexity    12694    12694           
=========================================
  Files          1029     1029           
  Lines        160321   160330    +9     
  Branches      35273    35273           
=========================================
+ Hits          43467    43472    +5     
- Misses       108920   108924    +4     
  Partials       7934     7934           
Impacted Files Coverage Δ
...eforge/kolmafia/persistence/AdventureDatabase.java 52.81% <100.00%> (+1.01%) ⬆️
...sourceforge/kolmafia/textui/langserver/Script.java 80.85% <0.00%> (-4.26%) ⬇️
...forge/kolmafia/textui/langserver/FilesMonitor.java 76.92% <0.00%> (-1.29%) ⬇️
...et/sourceforge/kolmafia/objectpool/Concoction.java 59.85% <0.00%> (-0.19%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 50.40% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08fe01...30a4ce3. Read the comment docs.

@Veracity0 Veracity0 enabled auto-merge (squash) August 9, 2022 15:14
@Veracity0 Veracity0 merged commit d85ee6e into main Aug 9, 2022
@Veracity0 Veracity0 deleted the more-adventure-validation branch August 9, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants