Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and simplify quest tracking with required outfits #973

Merged
merged 11 commits into from Aug 12, 2022

Conversation

Veracity0
Copy link
Contributor

@Veracity0 Veracity0 commented Aug 11, 2022

Dwarf Factory and Rift and Island and IsleWar disguised.

  • When choosing an outfit from several possible, if you are already wearing one, choose that, since the player made that choice.
  • Just like Player.withEquippableItem, Player.withEquipped now sets stat requirements and refreshes available outfits
  • canAdventure checks/chooses acceptable outfit
    prepareForAdventure equips the chosen outfit.
  • tests are updated to use withEquippableItem, as appropriate
  • Added tests for Cola Battlefield zones with Uniforms
  • If wearing Cola uniform, unequip shield in order to adventure in Battlefield (No Uniform)
  • Tests for dwarf factory

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #973 (b1a4565) into main (3590409) will increase coverage by 0.03%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #973      +/-   ##
============================================
+ Coverage     27.19%   27.23%   +0.03%     
- Complexity    12784    12833      +49     
============================================
  Files          1029     1029              
  Lines        160441   160478      +37     
  Branches      35313    35329      +16     
============================================
+ Hits          43637    43708      +71     
+ Misses       108813   108776      -37     
- Partials       7991     7994       +3     
Impacted Files Coverage Δ
.../net/sourceforge/kolmafia/objectpool/ItemPool.java 14.28% <ø> (ø)
src/net/sourceforge/kolmafia/KoLAdventure.java 36.03% <78.72%> (+3.55%) ⬆️
...sourceforge/kolmafia/session/EquipmentManager.java 34.00% <100.00%> (+0.16%) ⬆️
...et/sourceforge/kolmafia/session/IslandManager.java 8.86% <0.00%> (-1.37%) ⬇️
...ourceforge/kolmafia/persistence/QuestDatabase.java 29.62% <0.00%> (-0.38%) ⬇️
src/net/sourceforge/kolmafia/KoLCharacter.java 50.67% <0.00%> (+0.16%) ⬆️
src/net/sourceforge/kolmafia/SpecialOutfit.java 55.42% <0.00%> (+0.40%) ⬆️
...sourceforge/kolmafia/request/EquipmentRequest.java 20.87% <0.00%> (+1.39%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3590409...b1a4565. Read the comment docs.

@Veracity0 Veracity0 marked this pull request as ready for review August 11, 2022 23:12
@Veracity0 Veracity0 requested a review from a team as a code owner August 11, 2022 23:12
gausie
gausie previously approved these changes Aug 12, 2022
@Veracity0
Copy link
Contributor Author

Review comment addressed and previously approved.

@Veracity0 Veracity0 merged commit f403ac0 into main Aug 12, 2022
@Veracity0 Veracity0 deleted the validation-improvements branch August 12, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants