Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return acquired item from zap function #982

Merged
merged 4 commits into from Aug 14, 2022

Conversation

midgleyc
Copy link
Member

In Zap CLI command, add some extra text telling you what the item turned into (it's already there as "acquire", but for safety).

Add Zap ASH command that returns the item created.

As requested in https://kolmafia.us/threads/zap-returns-item-created.27874

@midgleyc midgleyc requested a review from a team as a code owner August 14, 2022 08:28
@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #982 (36b5073) into main (8527979) will increase coverage by 0.06%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #982      +/-   ##
============================================
+ Coverage     27.24%   27.31%   +0.06%     
- Complexity    12846    12874      +28     
============================================
  Files          1029     1029              
  Lines        160492   160508      +16     
  Branches      35330    35334       +4     
============================================
+ Hits          43733    43844     +111     
+ Misses       108764   108634     -130     
- Partials       7995     8030      +35     
Impacted Files Coverage Δ
...c/net/sourceforge/kolmafia/request/ZapRequest.java 56.14% <70.00%> (+11.37%) ⬆️
...et/sourceforge/kolmafia/textui/RuntimeLibrary.java 34.98% <100.00%> (+0.09%) ⬆️
...forge/kolmafia/persistence/ConcoctionDatabase.java 46.50% <0.00%> (-0.06%) ⬇️
...rceforge/kolmafia/persistence/HolidayDatabase.java 34.57% <0.00%> (ø)
...t/sourceforge/kolmafia/request/GenericRequest.java 23.77% <0.00%> (+0.19%) ⬆️
src/net/sourceforge/kolmafia/textui/DataTypes.java 49.55% <0.00%> (+0.22%) ⬆️
...eforge/kolmafia/persistence/EquipmentDatabase.java 70.88% <0.00%> (+0.22%) ⬆️
...ourceforge/kolmafia/request/CreateItemRequest.java 18.78% <0.00%> (+0.45%) ⬆️
...eforge/kolmafia/swingui/panel/ItemManagePanel.java 12.89% <0.00%> (+0.48%) ⬆️
...ge/kolmafia/swingui/panel/UseItemEnqueuePanel.java 36.11% <0.00%> (+0.74%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8527979...36b5073. Read the comment docs.

@midgleyc midgleyc merged commit c913e2d into kolmafia:main Aug 14, 2022
@midgleyc midgleyc deleted the zap-return-item branch August 14, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants