Adapt to changes in TypeRep complete patterns #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC merge request !963 improved the behaviour of the pattern match checker in the presence of COMPLETE annotations. This allows the removal of the
Fun
pattern from the complete setsCon, App
andCon', App
inData.Typeable.Internal
, which I expect to be done inGHC 9.4
(sobase 4.17
).As a result, we get a pattern match warning in
Data.Binary.Class.putTypeRep
, which this patch addresses.To be clear, the pattern was already redundant, it's just that GHC didn't see it because of how the
COMPLETE
pragmas used to be set up; callingputTypeRep (Fun arg res)
already went through through theApp
branch:Which indicates the
App
branch, and not theFun
branch (which uses the tag3
).