Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems with callbacks and killINotify #22

Merged
merged 3 commits into from Dec 3, 2016
Merged

Fix problems with callbacks and killINotify #22

merged 3 commits into from Dec 3, 2016

Commits on Nov 30, 2016

  1. Fix problems with callbacks and killINotify 

    1. We shouldn't run the callback inside mask_, because that prevents it
   from receiving StackOverflow, amongst other things.  I think this was
   a  n attempt to prevent the delivery of ThreadKilled inside the
   callback, but to do that you would need uninterruptibleMask_

2. killThread doesn't wait for the threads to die, so use the async
   package and cancel/wait instead.

3. If the killThread happens during a callback, we don't want to discard
   the exception, because that will leave the thread running.

I've added a new test for the problem of a callback hanging.
    @simonmar
    simonmar committed Nov 30, 2016
    Copy the full SHA
    2a29d8e View commit details
    Browse the repository at this point in the history

  2. Use bracket

    @simonmar
    simonmar committed Nov 30, 2016
    Copy the full SHA
    c50f3fa View commit details
    Browse the repository at this point in the history

  3. Remove redundant killINotify

    @simonmar
    simonmar committed Nov 30, 2016
    Copy the full SHA
    4f770e7 View commit details
    Browse the repository at this point in the history