Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #154 handle readonly array pushes #155

Merged
merged 1 commit into from Mar 30, 2020
Merged

Fix #154 handle readonly array pushes #155

merged 1 commit into from Mar 30, 2020

Conversation

kolodny
Copy link
Owner

@kolodny kolodny commented Mar 30, 2020

@kolodny kolodny mentioned this pull request Mar 30, 2020
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a1a87b9 on readonly-arrays into e5c1382 on master.

andreiglingeanu
andreiglingeanu approved these changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@andreiglingeanu andreiglingeanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as Array's are a superset of ReadonlyArray's AFAIK

@kolodny kolodny merged commit a1a87b9 into master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jednano jednano jednano approved these changes

@andreiglingeanu andreiglingeanu andreiglingeanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kolodny @coveralls @jednano @andreiglingeanu