Misc Update #2
Misc Update #2
Conversation
Also: - Allow replacing `zan check` with custom text - Make error message in custom checkers match react built-in
PropTypes.node is quite useful, so we shouldn't override this with element.
Rename old createCustomChecker() method to createSimpleChecker()
Also add createCustomCheckerCreator method
... Since this is not handled outside
|
looks good, I want to take a closer look before I merge |
|
👍 Look forward to hearing your feedback On Tuesday, February 16, 2016, Moshe Kolodny notifications@github.com
Sent from my iPhone |
|
@kolodny - Any timeframe for when you'll be able to get to this. I'm going to be publishing a library that depends on the updated version of zan, but would like to hold off until this is reviewed and merged. |
|
Sorry, I meant to get around to this sooner, this looks great. Thanks! It's published to |
|
@kolodny Thanks! This is great. Note, however, that the docs are now outdated. |
|
That's true, do you want to work on that? |
|
@kolodny Yeah, I'm fine making the update. Would you consider making me a contributor to the repo so I can do so on a branch? I won't merge w/out review. |
|
Done! |
|
👍 |
I forked zan and made a variety of changes to support my use-case. Changes include:
type.isOptional.isRequired.isOptional...inspectIsOptional()andinspectArgs()createCustomChecker()tocreateSimpleChecker(). Add.isOptionalhandling and inspection methods.createCustomChecker()method that makes it easy to add.isOptionalhandling and inspection methods to custom type checkers. Used internally forexactShape().If you'd like to merge these changes then please review. Once reviewed, I'll also update the documentation. Otherwise I'm happy to work off my fork.